[webkit-reviews] review requested: [Bug 173820] Web Inspector: Create a single -webkit-canvas for use inside popovers : [Attachment 314124] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jun 29 11:20:13 PDT 2017


Devin Rousso <drousso at apple.com> has asked  for review:
Bug 173820: Web Inspector: Create a single -webkit-canvas for use inside
popovers
https://bugs.webkit.org/show_bug.cgi?id=173820

Attachment 314124: Patch

https://bugs.webkit.org/attachment.cgi?id=314124&action=review




--- Comment #3 from Devin Rousso <drousso at apple.com> ---
Comment on attachment 314124
  --> https://bugs.webkit.org/attachment.cgi?id=314124
Patch

(In reply to Matt Baker from comment #2)
> Comment on attachment 314124 [details]
> Patch
> 
> r-, because after the change the Quick Open popover no longer has rounded
> bottom corners. This only occurs when the dialog resizes to show results.

This is unrelated.  I am seeing this issue without these changes.  Furthermore,
the Quick Open dialog doesn't even use a popover, so this shouldn't affect it
at all.


More information about the webkit-reviews mailing list