[webkit-reviews] review granted: [Bug 173941] VMTraps has some races : [Attachment 314096] Patch

[bugzilla-daemon at webkit.org]

Michael Saboff <msaboff at apple.com> has granted Keith Miller
<keith_miller at apple.com>'s request for review:
Bug 173941: VMTraps has some races
https://bugs.webkit.org/show_bug.cgi?id=173941

Attachment 314096: Patch

https://bugs.webkit.org/attachment.cgi?id=314096&action=review




--- Comment #7 from Michael Saboff <msaboff at apple.com> ---
Comment on attachment 314096
  --> https://bugs.webkit.org/attachment.cgi?id=314096
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=314096&action=review

r=me

> Source/JavaScriptCore/runtime/VMTraps.cpp:275
> +		       // FIXME: We need to use the machine threads because it
is the only non-TLS source
> +		       // for the stack bounds of this thread. We should keep
in on the WTF::Thread instead.

Add bug id for this FIXME.

> Source/JavaScriptCore/runtime/VMTraps.cpp:292
> +	   

nit: Revert whitespace.