[webkit-reviews] review granted: [Bug 173968] REGRESSION(r218896): ASSERT in WebPageProxy::dataCallback : [Attachment 314131] Patch

[bugzilla-daemon at webkit.org]

Michael Catanzaro <mcatanzaro at igalia.com> has granted Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 173968: REGRESSION(r218896): ASSERT in WebPageProxy::dataCallback
https://bugs.webkit.org/show_bug.cgi?id=173968

Attachment 314131: Patch

https://bugs.webkit.org/attachment.cgi?id=314131&action=review




--- Comment #2 from Michael Catanzaro <mcatanzaro at igalia.com> ---
Comment on attachment 314131
  --> https://bugs.webkit.org/attachment.cgi?id=314131
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=314131&action=review

> Source/WebCore/loader/DocumentLoader.cpp:1717
> +    RELEASE_ASSERT(callbackIdentifier);
> +    RELEASE_ASSERT(m_frame);

IMO there's no particular reason for these to be release asserts rather than
normal asserts.