[webkit-reviews] review granted: [Bug 173967] REGRESSION(r215347): NAS4Free Pop-down menus take 3 seconds to appear : [Attachment 314130] patch

[bugzilla-daemon at webkit.org]

Andreas Kling <akling at apple.com> has granted Antti Koivisto <koivisto at iki.fi>'s
request for review:
Bug 173967: REGRESSION(r215347): NAS4Free Pop-down menus take 3 seconds to
appear
https://bugs.webkit.org/show_bug.cgi?id=173967

Attachment 314130: patch

https://bugs.webkit.org/attachment.cgi?id=314130&action=review




--- Comment #3 from Andreas Kling <akling at apple.com> ---
Comment on attachment 314130
  --> https://bugs.webkit.org/attachment.cgi?id=314130
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=314130&action=review

r=me

> Source/WebCore/ChangeLog:3
> +	   NAS4Free Pop-down menus take 3 seconds to appear

Maybe you could tell us a bit more about this? Since you brought it up, I
mean.. If you hadn't, I would have accepted the patch as-is.

> Source/WebCore/ChangeLog:16
> +	       Trigger compositing update for non-composited layers on
visibility change.

Like you suggested on IRC, it would be nice to factor these checks out into a
helper function.