[webkit-reviews] review granted: [Bug 173912] Safari's Speedometer score massively regresses when accessibility is enabled : [Attachment 314070] Addressed Chris's comment

[bugzilla-daemon at webkit.org]

chris fleizach <cfleizach at apple.com> has granted Ryosuke Niwa
<rniwa at webkit.org>'s request for review:
Bug 173912: Safari's Speedometer score massively regresses when accessibility
is enabled
https://bugs.webkit.org/show_bug.cgi?id=173912

Attachment 314070: Addressed Chris's comment

https://bugs.webkit.org/attachment.cgi?id=314070&action=review




--- Comment #7 from chris fleizach <cfleizach at apple.com> ---
Comment on attachment 314070
  --> https://bugs.webkit.org/attachment.cgi?id=314070
Addressed Chris's comment

View in context: https://bugs.webkit.org/attachment.cgi?id=314070&action=review

small suggestions. otherwise change looks ok to me

> Source/WebCore/accessibility/AXObjectCache.cpp:2170
> +    textMarkerData.offset = 0;

these few lines should be unnecessary now that you initialize them

> Source/WebCore/accessibility/mac/AXObjectCacheMac.mm:412
> +    if (position.isNotNull()) {

should use early return here