[webkit-reviews] review denied: [Bug 173939] REGRESSION (r218616): Cannot build WebCore for macOS 10.12/iOS 10 with macOS 10.13/iOS 11 SDK : [Attachment 314057] Patch

[bugzilla-daemon at webkit.org]

mitz at webkit.org has denied Daniel Bates <dbates at webkit.org>'s request for
review:
Bug 173939: REGRESSION (r218616): Cannot build WebCore for macOS 10.12/iOS 10
with macOS 10.13/iOS 11 SDK
https://bugs.webkit.org/show_bug.cgi?id=173939

Attachment 314057: Patch

https://bugs.webkit.org/attachment.cgi?id=314057&action=review




--- Comment #2 from mitz at webkit.org ---
Comment on attachment 314057
  --> https://bugs.webkit.org/attachment.cgi?id=314057
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=314057&action=review

It’s incorrect to have the code call a different function at runtime depending
on what SDK was used at build time.

A correct fix for this bug would be to provide a declaration of the 10.12-era
SPI, properly annotated for availability, when using the 10.13-era or later
SDKs.

> Source/WebCore/platform/graphics/cocoa/FontCacheCoreText.cpp:1263
> +#if !USE_PLATFORM_SYSTEM_FALLBACK_LIST && ((PLATFORM(MAC) &&
__MAC_OS_X_VERSION_MAX_ALLOWED <= 101200) || (PLATFORM(IOS) &&
__IPHONE_OS_VERSION_MAX_ALLOWED <= 100000))

<= doesn’t make sense. Did you mean < 101300 and < 110000, respectively?

> Source/WebCore/platform/spi/cocoa/CoreTextSPI.h:132
> +#if (PLATFORM(MAC) && __MAC_OS_X_VERSION_MAX_ALLOWED <= 101200) ||
(PLATFORM(IOS) && __IPHONE_OS_VERSION_MAX_ALLOWED <= 100000)

Ditto.