[webkit-reviews] review granted: [Bug 173619] Web Inspector: use JSON::{Array, Object, Value} instead of Inspector{Array, Object, Value} : [Attachment 313529] Patch v1.1

[bugzilla-daemon at webkit.org]

Alex Christensen <achristensen at apple.com> has granted Brian Burg
<bburg at apple.com>'s request for review:
Bug 173619: Web Inspector: use JSON::{Array,Object,Value} instead of
Inspector{Array,Object,Value}
https://bugs.webkit.org/show_bug.cgi?id=173619

Attachment 313529: Patch v1.1

https://bugs.webkit.org/attachment.cgi?id=313529&action=review




--- Comment #8 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 313529
  --> https://bugs.webkit.org/attachment.cgi?id=313529
Patch v1.1

View in context: https://bugs.webkit.org/attachment.cgi?id=313529&action=review

r=me

>>> Source/JavaScriptCore/inspector/InspectorValues.h:52
>>> +namespace JSON {
>> 
>> Is this namespace used anywhere else?  How are you making JSON objects? 
Probably completely unrelated to this patch, but we've been meaning to
re-organize the JSON parser to use callbacks like the YARR parser so we can use
it for other things and remove json.hpp.  Would that help this project, too?
> 
> Unknown. I have never seen it, though.

I think I'd prefer this namespace be called something like "InspectorProtocol"
or "InspectorJSON" unless we want to make it purely for JSON and not have any
inspector anything inside it.