[webkit-reviews] review granted: [Bug 173903] Web Replay: remove some unused code : [Attachment 313978] Patch

[bugzilla-daemon at webkit.org]

Joseph Pecoraro <joepeck at webkit.org> has granted Brian Burg <bburg at apple.com>'s
request for review:
Bug 173903: Web Replay: remove some unused code
https://bugs.webkit.org/show_bug.cgi?id=173903

Attachment 313978: Patch

https://bugs.webkit.org/attachment.cgi?id=313978&action=review




--- Comment #3 from Joseph Pecoraro <joepeck at webkit.org> ---
Comment on attachment 313978
  --> https://bugs.webkit.org/attachment.cgi?id=313978
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=313978&action=review

rs=me

> Source/JavaScriptCore/ChangeLog:9
> +	   * Configurations/FeatureDefines.xcconfig:

This misses:
TestWebKitAPI/Configurations/FeatureDefines.xcconfig

> Source/WebCore/PlatformMac.cmake:-91
> -    "${WEBCORE_DIR}/ForwardingHeaders/replay"

You should be removing this directory as well. it contains:

./Source/WebCore/ForwardingHeaders/replay
./Source/WebCore/ForwardingHeaders/replay/EncodedValue.h
./Source/WebCore/ForwardingHeaders/replay/NondeterministicInput.h
./Source/WebCore/ForwardingHeaders/replay/InputCursor.h
./Source/WebCore/ForwardingHeaders/replay/EmptyInputCursor.h

> LayoutTests/ChangeLog:13
> +	   * inspector/replay/window-navigator-plugins-memoized.html: Removed.

TestExpectations:

$ find-expectations 'inspector/replay'
LayoutTests/TestExpectations:184:webkit.org/b/148036
http/tests/inspector/replay/ [ Skip ]
LayoutTests/TestExpectations:201:webkit.org/b/137130 inspector/replay [ Skip ]
LayoutTests/TestExpectations:210:webkit.org/b/131318
http/tests/inspector/replay/document-last-modified-fallback-value.html [ Skip ]

Another directory of tests:
http/tests/inspector/replay