[webkit-reviews] review granted: [Bug 173858] [Modern Media Controls] Accessibility labels should be formatted using NSDateComponentsFormatter. : [Attachment 313924] Patch

[bugzilla-daemon at webkit.org]

Dean Jackson <dino at apple.com> has granted Antoine Quint <graouts at apple.com>'s
request for review:
Bug 173858: [Modern Media Controls] Accessibility labels should be formatted
using NSDateComponentsFormatter.
https://bugs.webkit.org/show_bug.cgi?id=173858

Attachment 313924: Patch

https://bugs.webkit.org/attachment.cgi?id=313924&action=review




--- Comment #14 from Dean Jackson <dino at apple.com> ---
Comment on attachment 313924
  --> https://bugs.webkit.org/attachment.cgi?id=313924
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=313924&action=review

> Source/WebCore/Modules/mediacontrols/MediaControlsHost.cpp:292
> +String MediaControlsHost::formattedDuration(const double durationInSeconds)
const

I'm not sure about this name. Maybe formattedStringForDuration? or just
stringForDuration?

> Source/WebCore/rendering/RenderTheme.h:97
> +    virtual String mediaControlsFormattedDuration(const double) { return
String(); }

Ditto here.

> Source/WebCore/rendering/RenderThemeMac.mm:309
> +String RenderThemeMac::mediaControlsFormattedDuration(const double
durationInSeconds)

We don't have a RenderThemeCocoa?