[webkit-reviews] review denied: [Bug 173864] MediaStreamTrackPrivate observers map is used in various thread without protection. : [Attachment 313897] Patch

[bugzilla-daemon at webkit.org]

Chris Dumez <cdumez at apple.com> has denied youenn fablet <youennf at gmail.com>'s
request for review:
Bug 173864: MediaStreamTrackPrivate observers map is used in various thread
without protection.
https://bugs.webkit.org/show_bug.cgi?id=173864

Attachment 313897: Patch

https://bugs.webkit.org/attachment.cgi?id=313897&action=review




--- Comment #2 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 313897
  --> https://bugs.webkit.org/attachment.cgi?id=313897
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=313897&action=review

Please carefully protect ALL uses of m_observers.

> Source/WebCore/platform/mediastream/MediaStreamTrackPrivate.cpp:101
> +    ASSERT(isMainThread());

This is iterating over m_observers below but not locking, why?

> Source/WebCore/platform/mediastream/MediaStreamTrackPrivate.cpp:114
> +    ASSERT(isMainThread());

This is iterating over m_observers below but not locking, why?

> Source/WebCore/platform/mediastream/MediaStreamTrackPrivate.cpp:171
> +    ASSERT(isMainThread());

This is iterating over m_observers below but not locking, why?

> Source/WebCore/platform/mediastream/MediaStreamTrackPrivate.cpp:179
> +    ASSERT(isMainThread());

This is iterating over m_observers below but not locking, why?

> Source/WebCore/platform/mediastream/MediaStreamTrackPrivate.cpp:199
>      for (auto& observer : m_observers)

This is iterating over m_observers but not locking, why?

> Source/WebCore/platform/mediastream/MediaStreamTrackPrivate.cpp:211
>      for (auto& observer : m_observers)

This is iterating over m_observers but not locking, why?