[webkit-reviews] review requested: [Bug 173874] DocumentLoader should always notify the client if there are pending icon loads when the load is stopped : [Attachment 313911] Patch

[bugzilla-daemon at webkit.org]

Carlos Garcia Campos <cgarcia at igalia.com> has asked  for review:
Bug 173874: DocumentLoader should always notify the client if there are pending
icon loads when the load is stopped
https://bugs.webkit.org/show_bug.cgi?id=173874

Attachment 313911: Patch

https://bugs.webkit.org/attachment.cgi?id=313911&action=review




--- Comment #1 from Carlos Garcia Campos <cgarcia at igalia.com> ---
Created attachment 313911

  --> https://bugs.webkit.org/attachment.cgi?id=313911&action=review

Patch

I noticed this while working on moving the GTK+ and WPE APIs to use the new
icon loading client. The unit test reported memory leaks, because we keep a
reference of the web view in the icon loading decision callback, and the lambda
is not destroyed as expected when a new load happens. So, this will be covered
by GTK+ and WPE unit tests once I finish the migration.