[webkit-reviews] review granted: [Bug 173843] Disable m_temporarilyAllowingInlinePlaybackAfterFullscreen on pause : [Attachment 313888] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Jun 27 05:17:36 PDT 2017
Eric Carlson <eric.carlson at apple.com> has granted Jeremy Jones
<jeremyj-wk at apple.com>'s request for review:
Bug 173843: Disable m_temporarilyAllowingInlinePlaybackAfterFullscreen on pause
https://bugs.webkit.org/show_bug.cgi?id=173843
Attachment 313888: Patch
https://bugs.webkit.org/attachment.cgi?id=313888&action=review
--- Comment #3 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 313888
--> https://bugs.webkit.org/attachment.cgi?id=313888
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=313888&action=review
> LayoutTests/media/media-fullscreen-pause-inline-expected.txt:1
> +CONSOLE MESSAGE: Unhandled Promise Rejection: [object DOMError]
I think it would be better to handle and log the rejected promise so it shows
up in the in-page results when the test is run manually.
More information about the webkit-reviews
mailing list