[webkit-reviews] review granted: [Bug 173832] Refactor drag start codepaths to plumb a DragItem to client layers : [Attachment 313858] Attempt to fix Windows build

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has granted Wenson Hsieh
<wenson_hsieh at apple.com>'s request for review:
Bug 173832: Refactor drag start codepaths to plumb a DragItem to client layers
https://bugs.webkit.org/show_bug.cgi?id=173832

Attachment 313858: Attempt to fix Windows build

https://bugs.webkit.org/attachment.cgi?id=313858&action=review




--- Comment #3 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 313858
  --> https://bugs.webkit.org/attachment.cgi?id=313858
Attempt to fix Windows build

View in context: https://bugs.webkit.org/attachment.cgi?id=313858&action=review

It's a bit scary to expose DragItem like this to WebKit/WebKit2 but I guess
there isn't a good alternative here.
r=me.

> Source/WebKit2/Shared/WebCoreArgumentCoders.h:541
> +#if ENABLE(DRAG_SUPPORT)
> +template<> struct ArgumentCoder<WebCore::DragItem> {

Modern coding style is to implement encode/decode in WebCore right next to the
actual data type.