[webkit-reviews] review granted: [Bug 173804] REGRESSION (AsyncImageDecoding): A tab with the WWDC keynote paused is killed for using excessive power (Image thrashing) : [Attachment 313874] patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Antti Koivisto
<koivisto at iki.fi>'s request for review:
Bug 173804: REGRESSION (AsyncImageDecoding): A tab with the WWDC keynote paused
is killed for using excessive power (Image thrashing)
https://bugs.webkit.org/show_bug.cgi?id=173804

Attachment 313874: patch

https://bugs.webkit.org/attachment.cgi?id=313874&action=review




--- Comment #3 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 313874
  --> https://bugs.webkit.org/attachment.cgi?id=313874
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=313874&action=review

> Source/WebCore/platform/graphics/BitmapImage.cpp:229
> +		   imageObserver()->didDraw(*this);

It's confusing, and not very future-proof, to call something called 'didDraw'
when we didn't actually draw.

> LayoutTests/fast/images/low-memory-decode.html:15
> +    }, 100);

This will always take 100ms. Consider using shouldBecomeTrue().