[webkit-reviews] review granted: [Bug 173499] Resource Load Statistics: Add telemetry : [Attachment 313857] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jun 26 12:03:11 PDT 2017


Brent Fulgham <bfulgham at webkit.org> has granted John Wilander
<wilander at apple.com>'s request for review:
Bug 173499: Resource Load Statistics: Add telemetry
https://bugs.webkit.org/show_bug.cgi?id=173499

Attachment 313857: Patch

https://bugs.webkit.org/attachment.cgi?id=313857&action=review




--- Comment #24 from Brent Fulgham <bfulgham at webkit.org> ---
Comment on attachment 313857
  --> https://bugs.webkit.org/attachment.cgi?id=313857
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=313857&action=review

> LayoutTests/platform/wk2/TestExpectations:708
> +http/tests/loading/resourceLoadStatistics/telemetry-generation.html [ Pass ]

We should only need this line if it is skipped or marked as "Fail" at the top
level of LayoutTests. Is that the case here? It doesn't seem to be in this
patch.

I suspect you can get rid of this line.


More information about the webkit-reviews mailing list