[webkit-reviews] review granted: [Bug 173754] Web Inspector: Crash generating object preview for ArrayIterator : [Attachment 313768] [PATCH] Proposed Fix

[bugzilla-daemon at webkit.org]

Saam Barati <sbarati at apple.com> has granted Joseph Pecoraro
<joepeck at webkit.org>'s request for review:
Bug 173754: Web Inspector: Crash generating object preview for ArrayIterator
https://bugs.webkit.org/show_bug.cgi?id=173754

Attachment 313768: [PATCH] Proposed Fix

https://bugs.webkit.org/attachment.cgi?id=313768&action=review




--- Comment #9 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 313768
  --> https://bugs.webkit.org/attachment.cgi?id=313768
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=313768&action=review

r=me

> Source/JavaScriptCore/ChangeLog:9
> +	   When Inspector generates an object preview for an ArrayIterator
instance it made

I like how this patch turned out

> Source/JavaScriptCore/inspector/JSInjectedScriptHost.cpp:527
> +    JSObject* clone = constructEmptyObject(exec,
ArrayIteratorPrototype::create(vm, globalObject,
ArrayIteratorPrototype::createStructure(vm, globalObject,
globalObject->iteratorPrototype())));

Does the global object not cache this structure?