[webkit-reviews] review granted: [Bug 173677] Switch VMTraps to use halt instructions rather than breakpoint instructions : [Attachment 313750] Patch

[bugzilla-daemon at webkit.org]

JF Bastien <jfbastien at apple.com> has granted  review:
Bug 173677: Switch VMTraps to use halt instructions rather than breakpoint
instructions
https://bugs.webkit.org/show_bug.cgi?id=173677

Attachment 313750: Patch

https://bugs.webkit.org/attachment.cgi?id=313750&action=review




--- Comment #16 from JF Bastien <jfbastien at apple.com> ---
Comment on attachment 313750
  --> https://bugs.webkit.org/attachment.cgi?id=313750
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=313750&action=review

r=me

> Source/JavaScriptCore/ChangeLog:15
> +	   which should trigger a segmentation fault.

Drop "should". It triggers it :)

> Source/JavaScriptCore/runtime/VMTraps.cpp:123
> +    // ARM does not have any instruction guarenteed to segmentation fault.

ARM bit wrong?