[webkit-reviews] review granted: [Bug 173745] Consistently use RunLoop::isMain() in WebKit2 : [Attachment 313686] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jun 23 13:47:57 PDT 2017


Brent Fulgham <bfulgham at webkit.org> has granted Chris Dumez
<cdumez at apple.com>'s request for review:
Bug 173745: Consistently use RunLoop::isMain() in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=173745

Attachment 313686: Patch

https://bugs.webkit.org/attachment.cgi?id=313686&action=review




--- Comment #12 from Brent Fulgham <bfulgham at webkit.org> ---
Comment on attachment 313686
  --> https://bugs.webkit.org/attachment.cgi?id=313686
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=313686&action=review

Looks good. I was about to make this mistake in another patch! r=me.

> Source/WebKit2/Shared/CoordinatedGraphics/CoordinatedGraphicsScene.cpp:592
> +    bool calledOnMainThread = WTF::RunLoop::isMain();

Do we need WTF:: here? We don't use it elsewhere.


More information about the webkit-reviews mailing list