[webkit-reviews] review granted: [Bug 173689] REGRESSION (r218419): 3 NSMutableDictionary leaks calling -[WKProcessPool _pluginLoadClientPolicies] : [Attachment 313731] Patch v5

[bugzilla-daemon at webkit.org]

Tim Horton <thorton at apple.com> has granted David Kilzer (:ddkilzer)
<ddkilzer at webkit.org>'s request for review:
Bug 173689: REGRESSION (r218419): 3 NSMutableDictionary leaks calling
-[WKProcessPool _pluginLoadClientPolicies]
https://bugs.webkit.org/show_bug.cgi?id=173689

Attachment 313731: Patch v5

https://bugs.webkit.org/attachment.cgi?id=313731&action=review




--- Comment #23 from Tim Horton <thorton at apple.com> ---
Comment on attachment 313731
  --> https://bugs.webkit.org/attachment.cgi?id=313731
Patch v5

View in context: https://bugs.webkit.org/attachment.cgi?id=313731&action=review

> Source/WebKit2/ChangeLog:10
> +	   (policiesHashMapToDictionary): Use adoptNS().get() to avoid
> +	   dumping objects into autoreleasepools unnecessarily.

Why? Is this a wider policy we should have? We use autoreleased objects all
over the place.

> Source/WebKit2/ChangeLog:14
> +	   attribute to document that we're returning a new object on each
> +	   invocation.	I shouldn't have removed it in the v2 patch.

Quite.