[webkit-reviews] review denied: [Bug 173754] Web Inspector: Crash generating object preview for ArrayIterator : [Attachment 313688] [PATCH] Proposed Fix

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jun 23 12:05:15 PDT 2017


Joseph Pecoraro <joepeck at webkit.org> has denied Joseph Pecoraro
<joepeck at webkit.org>'s request for review:
Bug 173754: Web Inspector: Crash generating object preview for ArrayIterator
https://bugs.webkit.org/show_bug.cgi?id=173754

Attachment 313688: [PATCH] Proposed Fix

https://bugs.webkit.org/attachment.cgi?id=313688&action=review




--- Comment #5 from Joseph Pecoraro <joepeck at webkit.org> ---
Comment on attachment 313688
  --> https://bugs.webkit.org/attachment.cgi?id=313688
[PATCH] Proposed Fix

After talking with Saam going to go a safer route:

  - Only peek iterators when not observable (no user code)
  - Do a better job cloning ArrayIterators


More information about the webkit-reviews mailing list