[webkit-reviews] review granted: [Bug 173748] Avoid moving the same vector multiple times : [Attachment 313726] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jun 23 10:34:55 PDT 2017


Chris Dumez <cdumez at apple.com> has granted Brent Fulgham
<bfulgham at webkit.org>'s request for review:
Bug 173748: Avoid moving the same vector multiple times
https://bugs.webkit.org/show_bug.cgi?id=173748

Attachment 313726: Patch

https://bugs.webkit.org/attachment.cgi?id=313726&action=review




--- Comment #6 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 313726
  --> https://bugs.webkit.org/attachment.cgi?id=313726
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=313726&action=review

> Source/WebKit2/UIProcess/WebsiteData/WebsiteDataStore.cpp:516
> +	       for (const auto& topPrivatelyControlledDomain :
topPrivatelyControlledDomains) {

I think we prefer just "auto&" without const.


More information about the webkit-reviews mailing list