[webkit-reviews] review granted: [Bug 173751] Log when scripted animations get suspended and resumed : [Attachment 313680] Patch

[bugzilla-daemon at webkit.org]

Dean Jackson <dino at apple.com> has granted Antoine Quint <graouts at apple.com>'s
request for review:
Bug 173751: Log when scripted animations get suspended and resumed
https://bugs.webkit.org/show_bug.cgi?id=173751

Attachment 313680: Patch

https://bugs.webkit.org/attachment.cgi?id=313680&action=review




--- Comment #2 from Dean Jackson <dino at apple.com> ---
Comment on attachment 313680
  --> https://bugs.webkit.org/attachment.cgi?id=313680
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=313680&action=review

> Source/WebCore/ChangeLog:6
> +
> +	   Reviewed by NOBODY (OOPS!).

Explain that this is all an attempt to track down an impossible to reproduce
bug.

> Source/WebCore/dom/Document.cpp:6244
> +	       WTFLogAlways("\nDocument::requestAnimationFrame, %p", this);
> +	       WTFLogAlways("page? %p", page());

I think these should be a single line.

> Source/WebCore/dom/ScriptedAnimationController.cpp:83
> +	   WTFLogAlways("\nScriptedAnimationController::suspend(),
m_suspendCount = %d, %p", m_suspendCount, this);
> +	   WTFLogAlways("Document = %p", &m_document);

I think these should be a single line.

> Source/WebCore/dom/ScriptedAnimationController.cpp:99
> +	   WTFLogAlways("\nScriptedAnimationController::resume(),
m_suspendCount = %d, %p", m_suspendCount, this);
> +	   WTFLogAlways("Document = %p", &m_document);

I think these should be a single line.