[webkit-reviews] review granted: [Bug 173732] REGRESSION(r217695): Offscreen/overflowed items not being rendered while translating in-frame : [Attachment 313662] patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Antti Koivisto
<koivisto at iki.fi>'s request for review:
Bug 173732: REGRESSION(r217695): Offscreen/overflowed items not being rendered
while translating in-frame
https://bugs.webkit.org/show_bug.cgi?id=173732

Attachment 313662: patch

https://bugs.webkit.org/attachment.cgi?id=313662&action=review




--- Comment #4 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 313662
  --> https://bugs.webkit.org/attachment.cgi?id=313662
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=313662&action=review

> Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:1399
> +    auto bounds = FloatRect(m_boundsOrigin, size());
> +    if (auto extent = animationExtent()) {

Did you verify that bounds and extent are in the same coordinate space?

> Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:2303
> +	       ||
commitState.ancestorWithTransformAnimationIntersectsCoverageRect // FIXME:
Compute backing exactly for descendants of animating layers .

No space before period.

>
LayoutTests/compositing/backing/transform-transition-from-outside-view.html:33
> +	   .dot {
> +	       position: absolute;
> +	       top: 0;
> +	       left: 0;
> +	       height: 4px;
> +	       width: 4px;
> +	       background-color: silver;
> +	   }

You're not using dots.

>
LayoutTests/compositing/backing/transform-transition-from-outside-view.html:36
> +	       -webkit-transform: translateX(0px);

Transforms are unprefixed.