[webkit-reviews] review granted: [Bug 173557] [Curl] Extract CurlDownloadManager as shared background task handler : [Attachment 313653] Fix build error
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Jun 22 13:54:22 PDT 2017
Joseph Pecoraro <joepeck at webkit.org> has granted Basuke Suzuki
<Basuke.Suzuki at sony.com>'s request for review:
Bug 173557: [Curl] Extract CurlDownloadManager as shared background task
handler
https://bugs.webkit.org/show_bug.cgi?id=173557
Attachment 313653: Fix build error
https://bugs.webkit.org/attachment.cgi?id=313653&action=review
--- Comment #13 from Joseph Pecoraro <joepeck at webkit.org> ---
Comment on attachment 313653
--> https://bugs.webkit.org/attachment.cgi?id=313653
Fix build error
rs=me, but it would be good to describe how this solves the issue in the
ChangeLog.
I guess curl.h is smarter about checking if SOCKET is defined already? To avoid
the redefinition error:
C:\Program Files (x86)\Windows Kits\8.1\include\um\winsock2.h(111): error
C2371: 'SOCKET': redefinition; different basic types
More information about the webkit-reviews
mailing list