[webkit-reviews] review denied: [Bug 173730] Add SPI to WKURLSchemeTask for redirection : [Attachment 313649] Patch

[bugzilla-daemon at webkit.org]

Brady Eidson <beidson at apple.com> has denied Alex Christensen
<achristensen at apple.com>'s request for review:
Bug 173730: Add SPI to WKURLSchemeTask for redirection
https://bugs.webkit.org/show_bug.cgi?id=173730

Attachment 313649: Patch

https://bugs.webkit.org/attachment.cgi?id=313649&action=review




--- Comment #2 from Brady Eidson <beidson at apple.com> ---
Comment on attachment 313649
  --> https://bugs.webkit.org/attachment.cgi?id=313649
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=313649&action=review

> Source/WebKit2/ChangeLog:17
> +	   Right now just responding with an HTTP 301/302/307/308 response code
> +	   doesn't work because there is nothing that synthesizes an
NSURLRequest
> +	   from the Location header, and that would require using an
NSHTTPURLResponse
> +	   for non-HTTP responses, which is conceptually wrong.  Also, adding
such NSURLResponse
> +	   synthesizing to WebURLSchemeTaskProxy::didReceiveResponse like we do
in
> +	   SynchronousResourceHandleCFURLConnectionDelegate::willSendRequest et
al. for HSTS
> +	   would not work because we wouldn't properly do anything with the
completion handler
> +	   of ResourceLoader::willSendRequest.

I disagree about the conceptual wrongness.

Everything else here lists problems that can be solved with bug fixing in
current code, without expanding the API/SPI surface.

"for HSTS would not work because we wouldn't properly do anything with the
completion handler of ResourceLoader::willSendRequest."
I don't think there's actually a technical reason preventing this from working.