[webkit-reviews] review granted: [Bug 173727] REGRESSION (r217223): [iOS] Video keeps playing after application is backgrounded : [Attachment 313641] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jun 22 11:12:47 PDT 2017


Eric Carlson <eric.carlson at apple.com> has granted Jer Noble
<jer.noble at apple.com>'s request for review:
Bug 173727: REGRESSION (r217223): [iOS] Video keeps playing after application
is backgrounded
https://bugs.webkit.org/show_bug.cgi?id=173727

Attachment 313641: Patch

https://bugs.webkit.org/attachment.cgi?id=313641&action=review




--- Comment #3 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 313641
  --> https://bugs.webkit.org/attachment.cgi?id=313641
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=313641&action=review

> Source/WebCore/html/HTMLMediaElement.cpp:5342
> +    m_elementIsHidden = document().hidden() && m_videoFullscreenMode !=
VideoFullscreenModePictureInPicture;

Don't we also want to override when playing to AppleTV?


More information about the webkit-reviews mailing list