[webkit-reviews] review granted: [Bug 173306] [GStreamer] Spreaker live shows won't play : [Attachment 313619] Patch

[bugzilla-daemon at webkit.org]

Xabier Rodríguez Calvar <calvaris at igalia.com> has granted Charlie Turner
<cturner at igalia.com>'s request for review:
Bug 173306: [GStreamer] Spreaker live shows won't play
https://bugs.webkit.org/show_bug.cgi?id=173306

Attachment 313619: Patch

https://bugs.webkit.org/attachment.cgi?id=313619&action=review




--- Comment #5 from Xabier Rodríguez Calvar <calvaris at igalia.com> ---
Comment on attachment 313619
  --> https://bugs.webkit.org/attachment.cgi?id=313619
Patch

I can give you the r+ now but I am not totally convince of the structure. I
would either:

bool areCapsSet = false;
...
if (!areCapsSet)
   gst_app_src_set_caps(priv->appsrc, nullptr);

or even

GRefPtr<GstCaps> caps;
...
gst_app_src_set_caps(priv->appsrc, caps.get());