[webkit-reviews] review granted: [Bug 173626] Add logging to identify when the Page suspends scripted animations : [Attachment 313460] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jun 21 10:52:46 PDT 2017


Tim Horton <thorton at apple.com> has granted Antoine Quint <graouts at apple.com>'s
request for review:
Bug 173626: Add logging to identify when the Page suspends scripted animations
https://bugs.webkit.org/show_bug.cgi?id=173626

Attachment 313460: Patch

https://bugs.webkit.org/attachment.cgi?id=313460&action=review




--- Comment #4 from Tim Horton <thorton at apple.com> ---
Comment on attachment 313460
  --> https://bugs.webkit.org/attachment.cgi?id=313460
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=313460&action=review

> Source/WebKit/mac/WebView/WebPreferences.mm:674
> +	   [NSNumber numberWithBool:NO],
WebKitShouldLogScriptedAnimationControllerSuspensionChangePreferenceKey,

You have some objection to the modern @NO like the previous few lines?


More information about the webkit-reviews mailing list