[webkit-reviews] review granted: [Bug 173557] [Curl] Extract CurlDownloadManager as shared background task handler : [Attachment 313408] Fix

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jun 21 09:46:26 PDT 2017


Alex Christensen <achristensen at apple.com> has granted Basuke Suzuki
<Basuke.Suzuki at sony.com>'s request for review:
Bug 173557: [Curl] Extract CurlDownloadManager as shared background task
handler
https://bugs.webkit.org/show_bug.cgi?id=173557

Attachment 313408: Fix

https://bugs.webkit.org/attachment.cgi?id=313408&action=review




--- Comment #6 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 313408
  --> https://bugs.webkit.org/attachment.cgi?id=313408
Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=313408&action=review

> Source/WebCore/platform/network/curl/CookieJarCurl.cpp:252
> +    CURLSH* curlsh = CurlManager::shared().getCurlShareHandle();

We usually use "singleton" in WebKit instead of "shared"


More information about the webkit-reviews mailing list