[webkit-reviews] review denied: [Bug 173564] Cleanup FrameLoadRequest : [Attachment 313339] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Jun 20 15:20:57 PDT 2017
Brent Fulgham <bfulgham at webkit.org> has denied Daniel Bates
<dbates at webkit.org>'s request for review:
Bug 173564: Cleanup FrameLoadRequest
https://bugs.webkit.org/show_bug.cgi?id=173564
Attachment 313339: Patch
https://bugs.webkit.org/attachment.cgi?id=313339&action=review
--- Comment #16 from Brent Fulgham <bfulgham at webkit.org> ---
Comment on attachment 313339
--> https://bugs.webkit.org/attachment.cgi?id=313339
Patch
While I like the direction of this patch, the test failures make me concerned
that you have introduced changes in behavior, perhaps by unexpected changes in
how these objects are being initialized. I don't feel comfortable approving the
change with these failing tests.
More information about the webkit-reviews
mailing list