[webkit-reviews] review granted: [Bug 173577] Fix leak of ModuleInformations in BBQPlan constructors. : [Attachment 313373] Patch

[bugzilla-daemon at webkit.org]

Saam Barati <sbarati at apple.com> has granted Keith Miller
<keith_miller at apple.com>'s request for review:
Bug 173577: Fix leak of ModuleInformations in BBQPlan constructors.
https://bugs.webkit.org/show_bug.cgi?id=173577

Attachment 313373: Patch

https://bugs.webkit.org/attachment.cgi?id=313373&action=review




--- Comment #7 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 313373
  --> https://bugs.webkit.org/attachment.cgi?id=313373
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=313373&action=review

> Source/JavaScriptCore/ChangeLog:8
> +	   This patch fixes a leak in the BBQPlan constructiors. Previously,

Typo

> Source/JavaScriptCore/wasm/WasmBBQPlan.cpp:62
> +    : BBQPlan(vm, adoptRef(*new ModuleInformation(WTFMove(source))), work,
WTFMove(task))

I think we should make a create function for ModuleInformation

> Source/WTF/wtf/ThreadSafeRefCounted.h:33
> +#define CHECK_THREAD_SAFE_REF_COUNTED_LIFECYCLE 0

I’m not a huge fan of this checking code. I see that we do it for RefCounter as
well. IMO, it requires too many clients to call the relax function. I’m not
sure I get why many of them need to call this. Can you elaborate?

> Source/WTF/wtf/ThreadSafeRefCounted.h:90
> +inline void adopted(ThreadSafeRefCountedBase* refCounted)

Who calls this?