[webkit-reviews] review granted: [Bug 173552] bmalloc: Add a per-thread line cache : [Attachment 313353] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Geoffrey Garen <ggaren at apple.com>'s
request for review:
Bug 173552: bmalloc: Add a per-thread line cache
https://bugs.webkit.org/show_bug.cgi?id=173552

Attachment 313353: Patch

https://bugs.webkit.org/attachment.cgi?id=313353&action=review




--- Comment #4 from Darin Adler <darin at apple.com> ---
Comment on attachment 313353
  --> https://bugs.webkit.org/attachment.cgi?id=313353
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=313353&action=review

> Source/bmalloc/bmalloc/List.h:118
> +    static void remove(ListNode<T>* node)

The insertAfter function could also be marked static; why not?

> Source/bmalloc/bmalloc/SmallPage.h:71
> +typedef std::array<List<SmallPage>, sizeClassCount> LineCache;

In new code, we’ve been preferring using to typedef.