[webkit-reviews] review granted: [Bug 173573] repatchIn needs to lock the CodeBlock's lock : [Attachment 313348] patch

[bugzilla-daemon at webkit.org]

Yusuke Suzuki <utatane.tea at gmail.com> has granted Saam Barati
<sbarati at apple.com>'s request for review:
Bug 173573: repatchIn needs to lock the CodeBlock's lock
https://bugs.webkit.org/show_bug.cgi?id=173573

Attachment 313348: patch

https://bugs.webkit.org/attachment.cgi?id=313348&action=review




--- Comment #2 from Yusuke Suzuki <utatane.tea at gmail.com> ---
Comment on attachment 313348
  --> https://bugs.webkit.org/attachment.cgi?id=313348
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=313348&action=review

r=me

> Source/JavaScriptCore/jit/Repatch.cpp:560
>      if (tryRepatchIn(exec, base, ident, wasFound, slot, stubInfo) ==
GiveUpOnCache)
>	   ftlThunkAwareRepatchCall(exec->codeBlock(),
stubInfo.slowPathCallLocation(), operationIn);

BTW, how about passing the lock to these repatch functions? (const
AbstractLocker&). Of course, it should be done in a separate patch b/c it
involves other Get/Put changes.