[webkit-reviews] review granted: [Bug 173395] [WebIDL] Add support for serializers that have members that are themselves serializers (or inherit being a serializer from a parent) : [Attachment 313259] Patch

Mon Jun 19 13:11:46 PDT 2017

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Sam Weinig
<sam at webkit.org>'s request for review:
Bug 173395: [WebIDL] Add support for serializers that have members that are
themselves serializers (or inherit being a serializer from a parent)
https://bugs.webkit.org/show_bug.cgi?id=173395

Attachment 313259: Patch

https://bugs.webkit.org/attachment.cgi?id=313259&action=review

--- Comment #6 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 313259
  --> https://bugs.webkit.org/attachment.cgi?id=313259
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=313259&action=review

>
Source/WebCore/bindings/scripts/test/JS/JSTestSerializationIndirectInheritance.
cpp:18
> +    This library is free software; you can redistribute it and/or
> +    modify it under the terms of the GNU Library General Public
> +    License as published by the Free Software Foundation; either
> +    version 2 of the License, or (at your option) any later version.
> +
> +    This library is distributed in the hope that it will be useful,
> +    but WITHOUT ANY WARRANTY; without even the implied warranty of
> +    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
> +    Library General Public License for more details.
> +
> +    You should have received a copy of the GNU Library General Public
License
> +    along with this library; see the file COPYING.LIB.  If not, write to
> +    the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
> +    Boston, MA 02110-1301, USA.

Do we really put LGPL on new generated files?

> LayoutTests/fast/css/DOMQuad-serialization.html:1
> +<!DOCTYPE html>

This might already be tested by web platform tests?