[webkit-reviews] review granted: [Bug 173187] Web Inspector: Unify contextmenu items for all node links/previews : [Attachment 312565] Patch

[bugzilla-daemon at webkit.org]

Joseph Pecoraro <joepeck at webkit.org> has granted Devin Rousso
<drousso at apple.com>'s request for review:
Bug 173187: Web Inspector: Unify contextmenu items for all node links/previews
https://bugs.webkit.org/show_bug.cgi?id=173187

Attachment 312565: Patch

https://bugs.webkit.org/attachment.cgi?id=312565&action=review




--- Comment #7 from Joseph Pecoraro <joepeck at webkit.org> ---
Comment on attachment 312565
  --> https://bugs.webkit.org/attachment.cgi?id=312565
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=312565&action=review

r=me

> Source/WebInspectorUI/UserInterface/Views/ContextMenuUtilities.js:148
> +		   const options = {
> +		       ignoreNetworkTab: true,
> +		       ignoreSearchTab: true,
> +		   };
> +		   WebInspector.showSourceCodeLocation(sourceCodeLocation,
options);

I'd inline this object.

> Source/WebInspectorUI/UserInterface/Views/Main.css:343
> +    -webkit-user-select: none;

What if I want to select the selector in the sidebar or something?

> Source/WebInspectorUI/UserInterface/Views/RulesStyleDetailsPanel.js:189
> +		   const options = {
> +		       maxLength: 100,
> +		       excludeRevealElement: true,
> +		   };
> +		  
inheritedLabel.appendChild(WebInspector.linkifyNodeReference(style.node,
options));

Again, I'd inline this.