[webkit-reviews] review granted: [Bug 169293] Revert changes in bug#160417 about extending `null` not being a derived class : [Attachment 313228] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Jun 19 11:57:02 PDT 2017
Saam Barati <sbarati at apple.com> has granted GSkachkov <gskachkov at gmail.com>'s
request for review:
Bug 169293: Revert changes in bug#160417 about extending `null` not being a
derived class
https://bugs.webkit.org/show_bug.cgi?id=169293
Attachment 313228: Patch
https://bugs.webkit.org/attachment.cgi?id=313228&action=review
--- Comment #6 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 313228
--> https://bugs.webkit.org/attachment.cgi?id=313228
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=313228&action=review
> Source/JavaScriptCore/bytecompiler/NodesCodegen.cpp:3745
> + constructor =
generator.emitNewDefaultConstructor(generator.finalDestination(dst),
m_classHeritage ? ConstructorKind::Extends : ConstructorKind::Base, m_name,
ecmaName(), m_classSource);
style nit: no braces around "else" since this is just one line now
More information about the webkit-reviews
mailing list