[webkit-reviews] review granted: [Bug 172714] [Readable Streams API] Implement ReadableStreamBYOBReader read() : [Attachment 311692] Patch

[bugzilla-daemon at webkit.org]

youenn fablet <youennf at gmail.com> has granted Romain Bellessort
<romain.wkt at gmail.com>'s request for review:
Bug 172714: [Readable Streams API] Implement ReadableStreamBYOBReader read()
https://bugs.webkit.org/show_bug.cgi?id=172714

Attachment 311692: Patch

https://bugs.webkit.org/attachment.cgi?id=311692&action=review




--- Comment #3 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 311692
  --> https://bugs.webkit.org/attachment.cgi?id=311692
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=311692&action=review

> Source/WebCore/Modules/streams/ReadableByteStreamInternals.js:626
> +	   elementSize = view.BYTES_PER_ELEMENT;

BYTES_PER_ELEMENT is attached to the prototype, which may be changed for the
given view.
In that case, BYTES_PER_ELEMENT might be set to any value.
Given there is a FIXME below, we should also add one there I guess.