[webkit-reviews] review granted: [Bug 173513] [WebIDL] Properly model buffer source / typed arrays as their own IDL types : [Attachment 313212] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jun 19 09:14:02 PDT 2017


Alex Christensen <achristensen at apple.com> has granted Sam Weinig
<sam at webkit.org>'s request for review:
Bug 173513: [WebIDL] Properly model buffer source / typed arrays as their own
IDL types
https://bugs.webkit.org/show_bug.cgi?id=173513

Attachment 313212: Patch

https://bugs.webkit.org/attachment.cgi?id=313212&action=review




--- Comment #14 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 313212
  --> https://bugs.webkit.org/attachment.cgi?id=313212
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=313212&action=review

> Source/WebCore/bindings/js/JSDOMConvertUnion.h:38
> +struct ConditionalReturner;

Interesting.  I feel like there might be a better way to do this.


More information about the webkit-reviews mailing list