[webkit-reviews] review granted: [Bug 173526] Fix Ref to deref before assignment, add tests for this to RefPtr, Ref, Function : [Attachment 313244] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Jun 18 15:20:52 PDT 2017


Sam Weinig <sam at webkit.org> has granted Darin Adler <darin at apple.com>'s request
for review:
Bug 173526: Fix Ref to deref before assignment, add tests for this to RefPtr,
Ref, Function
https://bugs.webkit.org/show_bug.cgi?id=173526

Attachment 313244: Patch

https://bugs.webkit.org/attachment.cgi?id=313244&action=review




--- Comment #4 from Sam Weinig <sam at webkit.org> ---
Comment on attachment 313244
  --> https://bugs.webkit.org/attachment.cgi?id=313244
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=313244&action=review

> Source/WTF/ChangeLog:8
> +	   * wtf/Ref.h: Changed operator= to not be inlined. Added swap
functions.

I think you mean inline in the definition.  It is still inlined.


More information about the webkit-reviews mailing list