[webkit-reviews] review granted: [Bug 173519] Use WTF::Function instead of std::function in WTF/ : [Attachment 313219] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Jun 18 11:36:41 PDT 2017


Sam Weinig <sam at webkit.org> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 173519: Use WTF::Function instead of std::function in WTF/
https://bugs.webkit.org/show_bug.cgi?id=173519

Attachment 313219: Patch

https://bugs.webkit.org/attachment.cgi?id=313219&action=review




--- Comment #3 from Sam Weinig <sam at webkit.org> ---
Comment on attachment 313219
  --> https://bugs.webkit.org/attachment.cgi?id=313219
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=313219&action=review

> Source/WTF/wtf/text/WTFString.h:370
> +    using SplitFunctor = WTF::Function<void(const StringView&)>;
> +    WTF_EXPORT_STRING_API void split(UChar separator, bool
allowEmptyEntries, const SplitFunctor&) const;

This kind of basic algorithm seems like it should a template function and take
the functor as a template parameter.


More information about the webkit-reviews mailing list