[webkit-reviews] review granted: [Bug 173504] Use WTF::Function instead of std::function in WebKit2/ : [Attachment 313184] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 173504: Use WTF::Function instead of std::function in WebKit2/
https://bugs.webkit.org/show_bug.cgi?id=173504

Attachment 313184: Patch

https://bugs.webkit.org/attachment.cgi?id=313184&action=review




--- Comment #11 from Darin Adler <darin at apple.com> ---
Comment on attachment 313184
  --> https://bugs.webkit.org/attachment.cgi?id=313184
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=313184&action=review

I could not discern the pattern for where you were using WTF::Function and
where you were using Function without the explicit namespace.

If a function need to call a function one or more times before it returns, and
is definitely not intending to hold on to the function and call it later, and
in fact is not allowed to do so, what’s the best type to use for that argument?
WTF::Function&&? const WTF::Function&? Something else? That pattern does seem
to come up fairly often.

> Source/WebKit2/UIProcess/ProcessAssertion.h:27
>  #ifndef ProcessAssertion_h
>  #define ProcessAssertion_h

#pragma once?