[webkit-reviews] review granted: [Bug 173483] Port setup_environ_for_server should not set environment variables related with the driver. : [Attachment 313101] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Jun 17 00:13:41 PDT 2017


Carlos Garcia Campos <cgarcia at igalia.com> has granted Carlos Alberto Lopez
Perez <clopez at igalia.com>'s request for review:
Bug 173483: Port setup_environ_for_server should not set environment variables
related with the driver.
https://bugs.webkit.org/show_bug.cgi?id=173483

Attachment 313101: Patch

https://bugs.webkit.org/attachment.cgi?id=313101&action=review




--- Comment #2 from Carlos Garcia Campos <cgarcia at igalia.com> ---
Comment on attachment 313101
  --> https://bugs.webkit.org/attachment.cgi?id=313101
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=313101&action=review

> Tools/Scripts/webkitpy/port/base.py:871
> +	   # Use the driver _setup_environ_for_test() method for that..

Double . at the end.


More information about the webkit-reviews mailing list