[webkit-reviews] review granted: [Bug 173468] Crash due to infinite recursion via FrameSelection::updateAppearanceAfterLayout : [Attachment 313075] patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has granted Antti Koivisto <koivisto at iki.fi>'s
request for review:
Bug 173468: Crash due to infinite recursion via
FrameSelection::updateAppearanceAfterLayout
https://bugs.webkit.org/show_bug.cgi?id=173468

Attachment 313075: patch

https://bugs.webkit.org/attachment.cgi?id=313075&action=review




--- Comment #3 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 313075
  --> https://bugs.webkit.org/attachment.cgi?id=313075
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=313075&action=review

r=me with the timer in FrameSelection.

> Source/WebCore/ChangeLog:11
> +	   because itmay cause another call to resolveStyle. We have some cases
where the style

Nit: it *may.

> Source/WebCore/page/FrameView.cpp:350
> +    m_selectionAppearanceUpdateTimer.stop();

I think it's cleaner to add this timer in FrameSelection.

> LayoutTests/editing/selection/updateAppearanceAfterLayout-recursion.html:14
> +link.setAttribute("href", "data:text/css,"+Math.random());

It seems unnecessary to use Math.random()