[webkit-reviews] review granted: [Bug 173366] [iOS DnD] Upstream iOS drag and drop implementation into OpenSource WebKit : [Attachment 313143] Attempt to fix iOS build

[bugzilla-daemon at webkit.org]

Tim Horton <thorton at apple.com> has granted Wenson Hsieh
<wenson_hsieh at apple.com>'s request for review:
Bug 173366: [iOS DnD] Upstream iOS drag and drop implementation into OpenSource
WebKit
https://bugs.webkit.org/show_bug.cgi?id=173366

Attachment 313143: Attempt to fix iOS build

https://bugs.webkit.org/attachment.cgi?id=313143&action=review




--- Comment #3 from Tim Horton <thorton at apple.com> ---
Comment on attachment 313143
  --> https://bugs.webkit.org/attachment.cgi?id=313143
Attempt to fix iOS build

View in context: https://bugs.webkit.org/attachment.cgi?id=313143&action=review

This is half reviewed (the new bits) half rubber stamped (the existing code).

> Source/WebCore/Configurations/FeatureDefines.xcconfig:256
> +FEATURE_DEFINES = $(ENABLE_3D_TRANSFORMS) $(ENABLE_ACCELERATED_2D_CANVAS)
$(ENABLE_ACCELERATED_OVERFLOW_SCROLLING) $(ENABLE_APPLE_PAY)
$(ENABLE_APPLE_PAY_SESSION_V3) $(ENABLE_ATTACHMENT_ELEMENT)
$(ENABLE_AVF_CAPTIONS) $(ENABLE_CACHE_PARTITIONING) $(ENABLE_CANVAS_PATH)
$(ENABLE_CANVAS_PROXY) $(ENABLE_CHANNEL_MESSAGING) $(ENABLE_CONTENT_FILTERING)
$(ENABLE_CSS_ANIMATIONS_LEVEL_2) $(ENABLE_CSS_BOX_DECORATION_BREAK)
$(ENABLE_CSS_COMPOSITING) $(ENABLE_CSS_DEVICE_ADAPTATION)
$(ENABLE_CSS_IMAGE_ORIENTATION) $(ENABLE_CSS_IMAGE_RESOLUTION)
$(ENABLE_CSS_REGIONS) $(ENABLE_CSS_SCROLL_SNAP) $(ENABLE_CSS_SELECTORS_LEVEL4)
$(ENABLE_CSS_TRAILING_WORD) $(ENABLE_CSS3_TEXT) $(ENABLE_CURSOR_VISIBILITY)
$(ENABLE_CUSTOM_SCHEME_HANDLER) $(ENABLE_DASHBOARD_SUPPORT)
$(ENABLE_DATA_TRANSFER_ITEMS) $(ENABLE_DATACUE_VALUE)
$(ENABLE_DATALIST_ELEMENT) $(ENABLE_DEVICE_ORIENTATION)
$(ENABLE_ENCRYPTED_MEDIA) $(ENABLE_FAST_JIT_PERMISSIONS) $(ENABLE_FETCH_API)
$(ENABLE_FILTERS_LEVEL_2) $(ENABLE_FTL_JIT) $(ENABLE_FULLSCREEN_API)
$(ENABLE_GAMEPAD_DEPRECATED) $(ENABLE_GAMEPAD) $(ENABLE_GEOLOCATION)
$(ENABLE_ICONDATABASE) $(ENABLE_INDEXED_DATABASE_IN_WORKERS)
$(ENABLE_INDEXED_DATABASE) $(ENABLE_INPUT_TYPE_COLOR_POPOVER)
$(ENABLE_INPUT_TYPE_COLOR) $(ENABLE_INPUT_TYPE_DATE)
$(ENABLE_INPUT_TYPE_DATETIME_INCOMPLETE) $(ENABLE_INPUT_TYPE_DATETIMELOCAL)
$(ENABLE_INPUT_TYPE_MONTH) $(ENABLE_INPUT_TYPE_TIME) $(ENABLE_INPUT_TYPE_WEEK)
$(ENABLE_INTERSECTION_OBSERVER) $(ENABLE_INTL) $(ENABLE_IOS_GESTURE_EVENTS)
$(ENABLE_IOS_TOUCH_EVENTS) $(ENABLE_JIT) $(ENABLE_KEYBOARD_KEY_ATTRIBUTE)
$(ENABLE_KEYBOARD_CODE_ATTRIBUTE) $(ENABLE_LEGACY_CSS_VENDOR_PREFIXES)
$(ENABLE_LEGACY_ENCRYPTED_MEDIA) $(ENABLE_LEGACY_VENDOR_PREFIXES)
$(ENABLE_LETTERPRESS) $(ENABLE_LINK_PREFETCH) $(ENABLE_MAC_GESTURE_EVENTS)
$(ENABLE_MATHML) $(ENABLE_MEDIA_CAPTURE) $(ENABLE_MEDIA_CONTROLS_SCRIPT)
$(ENABLE_MEDIA_SESSION) $(ENABLE_MEDIA_SOURCE) $(ENABLE_MEDIA_STATISTICS)
$(ENABLE_MEDIA_STREAM) $(ENABLE_METER_ELEMENT) $(ENABLE_MHTML)
$(ENABLE_MOUSE_CURSOR_SCALE) $(ENABLE_NAVIGATOR_CONTENT_UTILS)
$(ENABLE_NAVIGATOR_HWCONCURRENCY) $(ENABLE_NOSNIFF) $(ENABLE_NOTIFICATIONS)
$(ENABLE_PDFKIT_PLUGIN) $(ENABLE_POINTER_LOCK) $(ENABLE_PROXIMITY_EVENTS)
$(ENABLE_PUBLIC_SUFFIX_LIST) $(ENABLE_QUOTA) $(ENABLE_REMOTE_INSPECTOR)
$(ENABLE_REQUEST_AUTOCOMPLETE) $(ENABLE_RESOLUTION_MEDIA_QUERY)
$(ENABLE_RESOURCE_USAGE) $(ENABLE_RUBBER_BANDING) $(ENABLE_SERVICE_CONTROLS)
$(ENABLE_SPEECH_SYNTHESIS) $(ENABLE_STREAMS_API) $(ENABLE_SUBTLE_CRYPTO)
$(ENABLE_SVG_FONTS) $(ENABLE_TELEPHONE_NUMBER_DETECTION)
$(ENABLE_TEXT_AUTOSIZING) $(ENABLE_TOUCH_EVENTS) $(ENABLE_TOUCH_ICON_LOADING)
$(ENABLE_USERSELECT_ALL) $(ENABLE_VARIATION_FONTS)
$(ENABLE_VIDEO_PRESENTATION_MODE) $(ENABLE_MAC_VIDEO_TOOLBOX)
$(ENABLE_VIDEO_TRACK) $(ENABLE_VIDEO) $(ENABLE_VIEW_MODE_CSS_MEDIA)
$(ENABLE_WEB_ANIMATIONS) $(ENABLE_WEB_AUDIO) $(ENABLE_WEB_REPLAY)
$(ENABLE_WEB_RTC) $(ENABLE_WEB_SOCKETS) $(ENABLE_WEB_TIMING)
$(ENABLE_WEBASSEMBLY) $(ENABLE_WEBGL) $(ENABLE_WEBGL2) $(ENABLE_WEBGPU)
$(ENABLE_WIRELESS_PLAYBACK_TARGET) $(ENABLE_XSLT) $(ENABLE_DRAG_SUPPORT)
$(ENABLE_DATA_INTERACTION);

This is sorted... please keep it that way!.

> Source/WebCore/platform/mac/DragDataMac.mm:110
> +    return String(kUTTypeTIFF);

Can we use the UTTypes ones on macOS too?