[webkit-reviews] review granted: [Bug 173495] Cleanup: WebContentMenuClient::searchWithGoogle() should parse URL using URL { URL { }, ... } instead of URL { ParsedURLString, ... } : [Attachment 313131] Patch

[bugzilla-daemon at webkit.org]

Alex Christensen <achristensen at apple.com> has granted Daniel Bates
<dbates at webkit.org>'s request for review:
Bug 173495: Cleanup: WebContentMenuClient::searchWithGoogle() should parse URL
using URL { URL { }, ... } instead of URL { ParsedURLString, ... }
https://bugs.webkit.org/show_bug.cgi?id=173495

Attachment 313131: Patch

https://bugs.webkit.org/attachment.cgi?id=313131&action=review




--- Comment #4 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 313131
  --> https://bugs.webkit.org/attachment.cgi?id=313131
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=313131&action=review

> Source/WebKit/win/WebCoreSupport/WebContextMenuClient.cpp:66
> +    String url = "http://www.google.com/search?q=" + encoded +
"&ie=UTF-8&oe=UTF-8";

I think makeString is even more efficient than calling operator+ twice.