[webkit-reviews] review granted: [Bug 173462] Handle timeout of prepareForPictureInPictureStopWithCompletionHandler. : [Attachment 313066] Patch

[bugzilla-daemon at webkit.org]

Jer Noble <jer.noble at apple.com> has granted Jeremy Jones
<jeremyj-wk at apple.com>'s request for review:
Bug 173462: Handle timeout of
prepareForPictureInPictureStopWithCompletionHandler.
https://bugs.webkit.org/show_bug.cgi?id=173462

Attachment 313066: Patch

https://bugs.webkit.org/attachment.cgi?id=313066&action=review




--- Comment #3 from Jer Noble <jer.noble at apple.com> ---
Comment on attachment 313066
  --> https://bugs.webkit.org/attachment.cgi?id=313066
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=313066&action=review

Looks good; just a couple of tiny nits.

> Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm:918
> -
> +    

Whitespace.

> Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm:957
> -
> +	   

Whitespace.

> Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm:1004
> -    LOG(Fullscreen,
"WebVideoFullscreenInterfaceAVKit::watchdogTimerFired(%p) - no exit fullscreen
response in %gs; forcing fullscreen hidden.", this,
defaultWatchdogTimerInterval);
> +    LOG(Fullscreen,
"WebVideoFullscreenInterfaceAVKit::watchdogTimerFired(%p) - no exit fullscreen;
forcing fullscreen hidden.", this);

Is this intentional?