[webkit-reviews] review granted: [Bug 173425] Uncaught Exception: TypeError: null is not an object (evaluating 'this.contentBrowser.contentViewForRepresentedObject') : [Attachment 313001] [PATCH] Proposed Fix

[bugzilla-daemon at webkit.org]

Devin Rousso <drousso at apple.com> has granted Joseph Pecoraro
<joepeck at webkit.org>'s request for review:
Bug 173425: Uncaught Exception: TypeError: null is not an object (evaluating
'this.contentBrowser.contentViewForRepresentedObject')
https://bugs.webkit.org/show_bug.cgi?id=173425

Attachment 313001: [PATCH] Proposed Fix

https://bugs.webkit.org/attachment.cgi?id=313001&action=review




--- Comment #5 from Devin Rousso <drousso at apple.com> ---
Comment on attachment 313001
  --> https://bugs.webkit.org/attachment.cgi?id=313001
[PATCH] Proposed Fix

r=me

View in context: https://bugs.webkit.org/attachment.cgi?id=313001&action=review

> Source/WebInspectorUI/ChangeLog:16
> +	   By default select a script/resource content view instead of nothing.

This sentence is awkward to me.

Always select a script/resource content view instead of nothing.

> Source/WebInspectorUI/UserInterface/Views/ContentBrowserTabContentView.js:98
>	   if (this.navigationSidebarPanel) {
>	       if (!this.navigationSidebarPanel.contentBrowser)
>		   this.navigationSidebarPanel.contentBrowser =
this._contentBrowser;
> +	   }

You can squash the two if statements:

if (this.navigationSidebarPanel && !this.navigationSidebarPanel.contentBrowser)
    this.navigationSidebarPanel.contentBrowser = this._contentBrowser;

> Source/WebInspectorUI/UserInterface/Views/ContentBrowserTabContentView.js:107
> +	   if (this.navigationSidebarPanel) {
>	       if (!this._contentBrowser.currentContentView)
>		   this.navigationSidebarPanel.showDefaultContentView();
>	   }

Ditto:

if (this.navigationSidebarPanel && !this._contentBrowser.currentContentView)
    this.navigationSidebarPanel.showDefaultContentView();