[webkit-reviews] review denied: [Bug 169293] Revert changes in bug#160417 about extending `null` not being a derived class : [Attachment 312963] Patch

[bugzilla-daemon at webkit.org]

Saam Barati <sbarati at apple.com> has denied GSkachkov <gskachkov at gmail.com>'s
request for review:
Bug 169293: Revert changes in bug#160417 about extending `null` not being a
derived class
https://bugs.webkit.org/show_bug.cgi?id=169293

Attachment 312963: Patch

https://bugs.webkit.org/attachment.cgi?id=312963&action=review




--- Comment #3 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 312963
  --> https://bugs.webkit.org/attachment.cgi?id=312963
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=312963&action=review

> Source/JavaScriptCore/bytecompiler/NodesCodegen.cpp:-3765
> -	       Ref<Label> superclassIsNullLabel = generator.newLabel();
> -	       Ref<Label> done = generator.newLabel();
> -
> -	       generator.emitJumpIfTrue(generator.emitUnaryOp(op_eq_null,
tempRegister.get(), superclass.get()), superclassIsNullLabel.get());
>	       generator.emitNewDefaultConstructor(constructor.get(),
ConstructorKind::Extends, m_name, ecmaName(), m_classSource);
>	       generator.emitLoad(tempRegister.get(), jsBoolean(true));
> -	       generator.emitJump(done.get());
> -	       generator.emitLabel(superclassIsNullLabel.get());
> -	       generator.emitNewDefaultConstructor(constructor.get(),
ConstructorKind::Base, m_name, ecmaName(), m_classSource);
> -	       generator.emitLoad(tempRegister.get(), jsBoolean(false));
> -	       generator.emitLabel(done.get());

Lets move back	to determining this property statically. There is no need for a
putById here, since it's always true!  Also, things that get this property
should also be able to determine its value statically.