[webkit-reviews] review granted: [Bug 172972] [ARMv6][DFG] ARM MacroAssembler is always emitting cmn when immediate is 0 : [Attachment 312984] Patch

[bugzilla-daemon at webkit.org]

Mark Lam <mark.lam at apple.com> has granted Caio Lima <ticaiolima at gmail.com>'s
request for review:
Bug 172972: [ARMv6][DFG] ARM MacroAssembler is always emitting cmn when
immediate is 0
https://bugs.webkit.org/show_bug.cgi?id=172972

Attachment 312984: Patch

https://bugs.webkit.org/attachment.cgi?id=312984&action=review




--- Comment #8 from Mark Lam <mark.lam at apple.com> ---
Comment on attachment 312984
  --> https://bugs.webkit.org/attachment.cgi?id=312984
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=312984&action=review

r=me.  Please fix the typo in the ChangeLog.

> Source/JavaScriptCore/ChangeLog:11
> +	   semantics of cmn is oposite of cmp[1]. One case that it's breaking
is

please fix typo: /oposite/opposite/