[webkit-reviews] review denied: [Bug 173385] Implement FALLTHROUGH macro for compilers other than Clang : [Attachment 312921] Patch

[bugzilla-daemon at webkit.org]

Michael Catanzaro <mcatanzaro at igalia.com> has denied Konstantin Tokarev
<annulen at yandex.ru>'s request for review:
Bug 173385: Implement FALLTHROUGH macro for compilers other than Clang
https://bugs.webkit.org/show_bug.cgi?id=173385

Attachment 312921: Patch

https://bugs.webkit.org/attachment.cgi?id=312921&action=review




--- Comment #3 from Michael Catanzaro <mcatanzaro at igalia.com> ---
Comment on attachment 312921
  --> https://bugs.webkit.org/attachment.cgi?id=312921
Patch

All the EWS bots are red, fix it please:

In file included from ../../Source/WTF/wtf/Platform.h:32:0,
		 from ../../Source/WTF/wtf/ExportMacros.h:32,
		 from ../../Source/JavaScriptCore/runtime/JSExportMacros.h:32,
		 from ../../Source/JavaScriptCore/config.h:26,
		 from
/home/ews/ltilve-gtk-wk2-ews/WebKit/Source/JavaScriptCore/disassembler/udis86/u
dis86_decode.c:27:
../../Source/WTF/wtf/Compiler.h:209:32: error: missing ')' after
"__has_attribute"
 #elif __has_cpp_attribute(clang::fallthrough)
				^
../../Source/WTF/wtf/Compiler.h:209:33: error:	':' without preceding '?'
 #elif __has_cpp_attribute(clang::fallthrough)
				 ^
../../Source/WTF/wtf/Compiler.h:211:30: error: missing ')' after
"__has_attribute"
 #elif __has_cpp_attribute(gnu::fallthrough)
			      ^
../../Source/WTF/wtf/Compiler.h:211:31: error:	':' without preceding '?'
 #elif __has_cpp_attribute(gnu::fallthrough)
			       ^